On Mon, 7 Jul 2025 23:21:58 GMT, Chen Liang <li...@openjdk.org> wrote:
> The class file API verifier seems to be based off a version of hotspot > verifier before Mar 3 2021. We are thus missing a few patches in the hotspot > verifier: > [JDK-8350029](https://bugs.openjdk.org/browse/JDK-8350029) > [JDK-8340110](https://bugs.openjdk.org/browse/JDK-8340110) > [JDK-8330606](https://bugs.openjdk.org/browse/JDK-8330606) > [JDK-8314295](https://bugs.openjdk.org/browse/JDK-8314295) > [JDK-8270398](https://bugs.openjdk.org/browse/JDK-8270398) > [JDK-8267118](https://bugs.openjdk.org/browse/JDK-8267118) > [JDK-8262368](https://bugs.openjdk.org/browse/JDK-8262368) > [JDK-8272096](https://bugs.openjdk.org/browse/JDK-8272096) > [JDK-8349923](https://bugs.openjdk.org/browse/JDK-8349923) > > Synchronization allows the ClassFile API verifier to catch up with upcoming > verification changes for Valhalla strict fields as well. > > Testing: select javac tests and classfile tests, running tier 1-3 src/java.base/share/classes/jdk/internal/classfile/impl/verifier/VerifierImpl.java line 143: > 141: // 8330606 Not applicable here > 142: return true; > 143: } It’s good that `ClassFile::verify(…)` will now verify these types. - https://github.com/openjdk/jdk/pull/19826#pullrequestreview-2382543361 ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26174#discussion_r2192958389