On Wed, 11 Jun 2025 07:31:48 GMT, erifan <d...@openjdk.org> wrote:
>> test/hotspot/jtreg/compiler/vectorapi/VectorMaskCompareNotTest.java line 158:
>>
>>> 156: } else if (op == VectorOperators.UGT) {
>>> 157: Asserts.assertEquals(compareUnsigned(a, b) <= 0, r);
>>> 158: }
>>
>> Please refactor it as a `switch`. And add a `default` case where you throw
>> some `RuntimeException`. just to make sure we are not missing anything :)
>
> `VectorOperators.XXX` is not compile time constants, we can't use `switch`
> here.
Oh. Ok. Well at least add a `RuntimeException` to an `else` branch then, I
would suggest :)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24674#discussion_r2139441633
