On Mon, 2 Jun 2025 13:46:23 GMT, Christian Stein <cst...@openjdk.org> wrote:

> Please review this fix to correctly parse tokens in an argument file that 
> contains trailing comments without preceding whitespace characters before the 
> '#' comment marker, the number sign.
> 
> The specifaction of the `java` Command has in section [java Command-Line 
> Argument 
> Files](https://docs.oracle.com/en/java/javase/12/docs/specs/man/java.html#java-command-line-argument-files):
> 
> Use the number sign `#` in the argument file to identify comments.
> All characters following the `#` are ignored until the end of line.
> 
> There is not requirement specified to prepend a comment in a line with at 
> least one argument with one or more preceding whitespace characters.

the fact that not including a space between the comment and the previous 
element created havoc seems to indicate that the scanner is pretty fragile and 
could break again in the future. We should probably file a follow up to make 
this code more reliable

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25589#issuecomment-2931287541

Reply via email to