On Fri, 30 May 2025 19:03:00 GMT, Sandhya Viswanathan <sviswanat...@openjdk.org> wrote:
>> Mohamed Issa has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Add newline back to templateInterpreterGenerator_x86_64.cpp source file >> - Add special case values to cbrt micro-benchmark set > > src/hotspot/cpu/x86/assembler_x86.cpp line 2879: > >> 2877: emit_operand(dst, src, 0); >> 2878: } >> 2879: > > One more change is needed. We need to set address attributes here, as movapd > has Address as one of the input: > `attributes.set_address_attributes(/* tuple_type */ EVEX_FVM, /* > input_size_in_bits */ EVEX_NObit);` > This should be done before call to simd_prefix. I added the change and re-ran the tests. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24470#discussion_r2116518295
