On Fri, 30 May 2025 00:41:12 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with one additional >> commit since the last revision: >> >> re-add testCompat to Bug8167143.java > > test/jdk/java/util/TimeZone/Bug8167143.java line 102: > >> 100: case "testCompat": >> 101: testImplicitCompatLocales(); >> 102: break; > > The method name is deceiving, but the test still has value because it tests > the internal `FALLBACK` provider. In fact, functions for `BreakIterator` and > `Collator` should be fully functional from that provider, as `CLDR` provider > does not provide those. Maybe renaming `Compat` to `Fallback` would be > appropriate. The run invocation for `testCompat` was removed from the Jtreg header in [JDK-8174269](https://bugs.openjdk.org/browse/JDK-8174269). So since then, that test was not run, which was why I removed it. I tried re-adding this test as part of the run directives, and it fails. (I presume that's why it was removed after COMPAT removal.) It is testing the JRE provider, we can repurpose the test to check the FALLBACK provider, but we would only expect the implicit locales for BreakIteratorProvider and CollatorProvider (as you said). I filed [JDK-8358170](https://bugs.openjdk.org/browse/JDK-8358170) because I think this change would be out of scope for this issue. I simply reverted the removal in the https://github.com/openjdk/jdk/pull/25532/commits/d8da77440d6ed63dee6444dda549279cc15ae918. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25532#discussion_r2116268074
