On Fri, 30 May 2025 01:31:12 GMT, Chen Liang <li...@openjdk.org> wrote:

> For some reason the lines you've added for UOE in MOAT are failing; can you 
> check?

This was due to the merge with 
https://github.com/openjdk/jdk/commit/fbc4691bfa11f31601fd89d05da63e689343e214, 
I resolved the conflict in the test but missed that the change adds a new 
`AbstractImmutableMap` implementation, and the `keySet` doesn't throw UOE on 
modifications. I have an initial changes that has MOAT passing again, but that 
part may require more thought.

> I have reviewed the CSR for you. Maybe us, Per Minborg, and Stuart Marks can 
> work together to get the two significant collection changes into early 26 and 
> broadcast on quality discuss list, as otherwise corpus analysis provides 
> little useful information on the compatibility impact.

Thanks, that sounds great!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/18522#issuecomment-2921055604

Reply via email to