On Fri, 30 May 2025 01:45:41 GMT, Alexander Matveev <almat...@openjdk.org> 
wrote:

>> - `--install-dir` option in DMG packaging is no longer ignored.
>> - Defaults are still the same: `/Applications` and 
>> `/Library/Java/JavaVirtualMachines`.
>> - It will be user responsibility to make sure installation directory exist 
>> on target machine, since DMG cannot create directories during drag and drop.
>> - Target directory in case of non-default installation dir will display full 
>> path. See image below for example.
>> 
>> ![Screenshot 2025-05-28 at 12 07 53 
>> AM](https://github.com/user-attachments/assets/fbcba07b-74a5-4276-90c3-5f8d2d0dcc16)
>
> Alexander Matveev has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   8351369: [macos] Use --install-dir option with DMG packaging [v2]

Marked as reviewed by asemenyuk (Reviewer).

The fix looks neat and clean 👍. Thank you!

-------------

PR Review: https://git.openjdk.org/jdk/pull/25481#pullrequestreview-2880017354
PR Comment: https://git.openjdk.org/jdk/pull/25481#issuecomment-2921035472

Reply via email to