On Thu, 29 May 2025 08:36:31 GMT, Jatin Bhateja <jbhat...@openjdk.org> wrote:
>> Mohamed Issa has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - Remove comment mentioning invalid exception when NaN input is provided >> - Use rcx as base and r8 as index for address calculations in certain cbrt >> stub generator instructions >> - Remove unnecessary unpckhpd and unpcklpd definitions in macro-assembler >> header file >> - Remove unnecessary movapd definitions in macro-assembler header file > > Patch looks good to me, some comment included. @jatin-bhateja Please let me know if there's anything else to address. ------------- PR Comment: https://git.openjdk.org/jdk/pull/24470#issuecomment-2920726222