On Wed, 28 May 2025 03:35:40 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
> Various enhancements of jpackage test helpers: > - Can run fa tests when JAVA_TOOL_OPTIONS env variable contains > `--module-path` option. This change makes support for > `jpackage.test.clear-app-launcher-java-env-vars` system property redundant. > - Rework JUnitAdapter to make it run jpackage TestInstance objects as JUnit5 > DynamicTest tests. This integrates jpackage test runs in IDEs (Verified with > Eclipse IDE). > - Make jpackage tests fail fast when they are executed by JUnit test runner. > - Applied `./bin/blessed-modifier-order.sh` script on jpackage test helpers. > - Support loading jpackage tests from a custom classloader. > - Add support for using a custom ToolProvider implementation of jpackage > with JPackageCommand. > > The last two features are not currently in use. They were picked from the > work-in-progress [JDK-8333727](https://bugs.openjdk.org/browse/JDK-8333727). Looks good. ------------- Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25479#pullrequestreview-2879654342