On Thu, 29 May 2025 21:15:57 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which removes the test tool `GenerateKeyList.java`
>> after the COMPAT locale data removal.
>>
>> `LocaleDataTest.java` may optionally use the `GenerateKeyList.java` tool.
>> However, this tool is manually used and was primarily used for COMPAT data.
>> There is no longer any point to keep it, and it can always be retrieved via
>> the VCS if needed.
>
> Justin Lu has updated the pull request incrementally with one additional
> commit since the last revision:
>
> reflect some corrections
test/jdk/sun/text/resources/LocaleDataTest.java line 333:
> 331: || rbName.equals("TimeZoneNames")) {
> 332: fullName = UTIL_RESOURCES_PACKAGE + "." + rbName;
> 333: } else if (rbName.equals("CollationData")) {
CLDR does not define CollationData, so this type of check actually needs to be
removed, since we should not be including any CLDR data in the LocaleData.cldr
file in the first place.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25527#discussion_r2114760076
