Re: RFR: 8356634: VectorShape#largestShapeFor should have public access

[Paul Sandoz]

On Wed, 28 May 2025 21:22:30 GMT, Ian Graves <igra...@openjdk.org> wrote:

> VectorShape#largestShapeFor is referenced in existing JavaDoc but has been 
> package-private. This propose change makes it public and adds documentation 
> for it.

Can you add something to the method testVectorShape in 
test/jdk/jdk/incubator/vector/PreferredSpeciesTest.java?

src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorShape.java 
line 218:

> 216:      * @return the largest vector shape supported by the platform
> 217:      * for {@code etype}
> 218:      * @throws IllegalArgumentException if no such vector shape exists

Suggestion:

     * @throws IllegalArgumentException if no such vector shape exists
     *         for the element type or the type is not a valid {@code ETYPE}.

-------------

PR Review: https://git.openjdk.org/jdk/pull/25513#pullrequestreview-2876648963
PR Review Comment: https://git.openjdk.org/jdk/pull/25513#discussion_r2112895191