On Thu, 22 May 2025 11:42:04 GMT, Jaikiran Pai <j...@openjdk.org> wrote:
>> Henry Jen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Validator to take a file, use term JAR file > > test/jdk/tools/jar/ValidatorTest.java line 60: > >> 58: import jdk.test.lib.util.FileUtils; >> 59: >> 60: @TestInstance(Lifecycle.PER_CLASS) > > I haven't seen this used commonly in our tests. Is there something specific > in this test that requires this usage? I take this in as other jar tests. I think it's because we used to share the ZIP file between tests. I believe I can remove it for this test. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24430#discussion_r2103031299