On Mon, 24 Mar 2025 22:33:56 GMT, Jason Zaugg <jza...@openjdk.org> wrote:
>> Good catch, thanks! Ordinarily, I would say a test is required, but I can't >> think up a viable test to verify the effect of this change in a test, so we >> probably need to do it without a test. > >> Ordinarily, I would say a test is required, but I can't think up a viable >> test to verify the effect of this change in a test, so we probably need to >> do it without a test. > > I tested this change > [externally](https://github.com/retronym/jarcache/blob/ba7f5cdd5f7db976a6568855a0d517f52a1404bf/demo/src/test/scala/demo/JarCacheAgentTest.java#L75-L76) > with [JFRUnit](https://github.com/moditect/jfrunit). > > If preferred, I could create a `jtreg` test along similar lines. It would use > the JFR API directly to capture `jdk.FileRead` events. The test would > construct a JAR that previously triggered one read per entry, and assert that > after this change, only a single read is needed to initialize a compiler > whose classpath includes that JAR. @retronym Great to see you here, Jason! I hope all is well. :) ------------- PR Comment: https://git.openjdk.org/jdk/pull/24176#issuecomment-2900199480
