On Tue, 20 May 2025 10:54:44 GMT, He-Pin(kerr) <d...@openjdk.org> wrote:

>> Motivation:
>> When a user passes a wrong parameter, the current implementation throws an 
>> IllegalArgumentException with an error message `null`, which is not helpful.
>> 
>> Modification:
>> Add detail error messages.
>> 
>> Result:
>> Helpful messages.
>
> He-Pin(kerr) has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Update 
> src/java.base/share/classes/java/util/concurrent/AbstractExecutorService.java
>    
>    Co-authored-by: Viktor Klang <viktor.kl...@oracle.com>
>  - Update 
> src/java.base/share/classes/java/util/concurrent/AbstractExecutorService.java
>    
>    Co-authored-by: Viktor Klang <viktor.kl...@oracle.com>

Thanks for your work here, @He-Pin

-------------

Marked as reviewed by vklang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23050#pullrequestreview-2858828972

Reply via email to