> The test was originally written with product builds in mind; it didn't 
> consider the slowness of debug builds, thus causing tests to fail.
> 
> Also there was a bug in testWeakAgainstClassValue: the test need to flush the 
> backing map in the class to have the weak value removed. It is fixed in this 
> patch as well.
> 
> Testing: ClassValueTest repeated 10 times on 
> windows-x64/linux-x64/macosx-aarch64/linux-aarch64 fastdebug.

Chen Liang has updated the pull request with a new target base due to a merge 
or a rebase. The incremental webrev excludes the unrelated changes brought in 
by the merge/rebase. The pull request contains four additional commits since 
the last revision:

 - Increase timeout, add comment for adjust for debugging
 - Merge branch 'master' of https://github.com/openjdk/jdk into 
fix/cv-test-problems
 - Restore incorrectly removed annotation
 - Fix problems with class value tests

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25292/files
  - new: https://git.openjdk.org/jdk/pull/25292/files/792d683e..68a13bb3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25292&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25292&range=00-01

  Stats: 36448 lines in 506 files changed: 23222 ins; 10278 del; 2948 mod
  Patch: https://git.openjdk.org/jdk/pull/25292.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25292/head:pull/25292

PR: https://git.openjdk.org/jdk/pull/25292

Reply via email to