On Mon, 19 May 2025 23:53:07 GMT, Shaojin Wen <s...@openjdk.org> wrote:

>> Improve the performance of UUID::toString by using Long.expand and SWAR 
>> (SIMD within a register) instead of table lookup. Eliminating the table 
>> lookup can also avoid the performance degradation problem when the cache 
>> misses.
>
> Shaojin Wen has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   hex8 comments

src/java.base/share/classes/java/util/UUID.java line 492:

> 490:      * achieving significantly better performance compared to 
> traditional loop-based conversion.
> 491:      *
> 492:      * <p>The conversion algorithm works as follows:

I think the in-line comment describing the algorithm is enough - doesn't need 
the details in the javadoc as well.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22928#discussion_r2099078808

Reply via email to