On Wed, 14 May 2025 21:02:20 GMT, Markus KARG <d...@openjdk.org> wrote:
>> Both `subSequence` and `getChars` are implemented by the CharSequence. >> They have the same level of trustworthiness about their implementation. > > I meant that the implementation of `subSequence` *might or might not* perform > copy (so we need to tell the javaDoc reader), while `getChar` *clearly* > performs a copy as part of it design. So `subSequence` can be surprising as > this discussion proofs, while `getChars` will not. That was Stuart's point > with `read`, and that was your point with `CharSequence`. @mkarg Please don't invoke my name to try to buttress your arguments. The calls the Reader.of() instance makes on its backing CharSequence is a different kind of issue from what promises or guarantees the concrete methods of the Reader class makes to its subclasses. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24728#discussion_r2089846252
