On Tue, 6 May 2025 21:45:55 GMT, Jorn Vernee <jver...@openjdk.org> wrote:
>> Chen Liang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 12 additional >> commits since the last revision: >> >> - Simplify to utility class >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> fix/ffm-opt-capture-states >> - Update >> src/java.base/share/classes/jdk/internal/foreign/abi/CapturableState.java >> >> Co-authored-by: Shaojin Wen <shaojin.we...@alibaba-inc.com> >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> fix/ffm-opt-capture-states >> - Merge branch 'master' of https://github.com/openjdk/jdk into >> fix/ffm-opt-capture-states >> - rollback OS >> - Review remarks >> - No env to test >> >> - Unchecked >> >> - Further revamp, remove unnecessary instances on irrelevant platforms >> >> - ... and 2 more: https://git.openjdk.org/jdk/compare/e1e77797...0f495539 > > src/java.base/share/classes/jdk/internal/foreign/abi/CapturableState.java > line 62: > >> 60: "errno", 1 << 2 >> 61: ); >> 62: } > > Pre-existing, but while you're here, could you add a comment stating that the > mask values have to be kept in sync with the value in > `DowncallLinker::capture_state` in > `src/hotspot/share/prims/downcallLinker.cpp`? (See > https://github.com/openjdk/jdk/blob/master/src/hotspot/share/prims/downcallLinker.cpp#L36) Done. Added in the MASKS field declaration. Also updated the outdated class name reference in downcallLinker.cpp. (Missed c++ file name in first push, c++ file name is not that easy to discover) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25025#discussion_r2076415819
