On Thu, 1 May 2025 08:45:06 GMT, Markus KARG <d...@openjdk.org> wrote:

>> This Pull Request proposes an implementation for 
>> [JDK-8343110](https://bugs.openjdk.org/browse/JDK-8343110): Adding the new 
>> method `public void getChars(int srcBegin, int srcEnd, char[] dst, int 
>> dstBegin)` to the `CharSequence` interface, providing a **bulk-read** 
>> facility including a default implementation iterating over `charAt(int)`.
>> 
>> In addition, this Pull Request proposes to replace the implementation of 
>> `Reader.of(CharSequence).read(char[] cbuf, int off, int len)` to invoke 
>> `CharSequence.getChars(next, next + n, cbuf, off)` instead of utilizing 
>> pattern matching for switch. Also, this PR proposes to implement 
>> `CharBuffer.getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)` as 
>> an alias for `CharBuffer.get(srcBegin, dst, dstBegin, srcEnd - srcBegin)`.
>> 
>> To ensure quality...
>> * ...the method signature and JavaDocs are adapted from 
>> `AbstractStringBuilder.getChars(...)`.
>> * ...this PR relies upon the existing tests for `Reader.of(CharSequence)`, 
>> as these provide sufficient coverage of all changes introduced by this PR.
>
> Markus KARG has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Applied proposal by Daniel: If there's no change to this file the copyright 
> year update could be reverted?

I know all that. As I said, I am using git since decades, so I know *lots* of 
alternative ways to update branches and even proposed the one you want, so I 
just needed to know *which of those alternatives* (not the exact commands) you 
*want*. Don't know why posted all that, as the question was already solved by 
you?! 🤔

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21730#issuecomment-2855388011

Reply via email to