On Mon, 5 May 2025 17:32:19 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Refactor AbstractStringBuilder to maintain consistency among count, coder, >> and value buffers while the buffer capacity is being expanded and/or >> inflated from Latin1 to UTF16 representations. >> The refactoring pattern is to read and write AbstractStringBuilder fields >> once using locals for all intermediate values. >> Support methods are static, designed to pass all values as arguments and >> return a value. >> >> The value byte array is reallocated under 3 conditions: >> - Increasing the capacity with the same encoder >> - Increasing the capacity and inflation to change the coder from LATIN1 to >> UTF16 >> - Inflation with the same capacity >> >> Added StressSBTest to exercise public instance methods of StringBuilder. > > Roger Riggs has updated the pull request incrementally with one additional > commit since the last revision: > > Refactor to consistently use `isLatin1(coder)` within AbstractStringBuilder. Some of the files will need a copyright year update. test/jdk/java/lang/StringBuilder/StressSBTest.java line 72: > 70: /** > 71: * Stress test using a number of platform threads for a duration. > 72: * Success is marked by a lack of exceptions. If I'm reading the test correctly, then the exceptions that happen in the launched thread are merely logged and thus the test will never throw any exceptions and will never fail? ------------- PR Comment: https://git.openjdk.org/jdk/pull/24967#issuecomment-2854691855 PR Review Comment: https://git.openjdk.org/jdk/pull/24967#discussion_r2075546963
