On Mon, 5 May 2025 18:21:44 GMT, ExE Boss <d...@openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Fix empty line at the end of a third file
>> - Fix empty line at the end of another file
>> - Fix empty line at the end of a file
>
> src/java.base/share/classes/jdk/internal/foreign/BufferStack.java line 176:
>
>> 174: @ForceInline
>> 175: @Override
>> 176: public NativeMemorySegmentImpl allocateNoInit(long
>> byteSize, long byteAlignment) {
>
> This probably also needs `@SuppressWarnings("restricted")`:
> Suggestion:
>
> @ForceInline
> @Override
> @SuppressWarnings("restricted")
> public NativeMemorySegmentImpl allocateNoInit(long byteSize, long
> byteAlignment) {
I can't see why that is needed? Which restricted method is called by this
method? What did I miss?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25043#discussion_r2075344707
