On Fri, 2 May 2025 19:06:58 GMT, Shaojin Wen <s...@openjdk.org> wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Lance's review - update code comment in the test > > src/java.base/share/classes/java/util/zip/ZipFile.java line 1240: > >> 1238: entries[index] = hash; >> 1239: entries[index + 1] = next; >> 1240: entries[index + 2] = pos; > > Suggestion: > > entries[index ] = hash; > entries[index + 1] = next; > entries[index + 2] = pos; > > Aligned code is more readable Hello Shaojin, leaving one or more spaces before a closing `]` bracket of array access contradicts the style that I've seen used often in the code. At least it's not a common style used in this area of the code in the JDK. I think it's fine in the current form and changing it to align with subsequent lines isn't necessary. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23986#discussion_r2073207272
