On Sun, 4 May 2025 16:21:41 GMT, Markus KARG <d...@openjdk.org> wrote:

>> This Pull Requests proposes an implementation for 
>> [JDK-8353795](https://bugs.openjdk.org/browse/JDK-8353795): Adding the new 
>> method `public static Writer Writer.of(StringBuilder)`, providing a 
>> non-synchronized Writer implementation optimized for writing into 
>> `StringBuilder`.
>> 
>> A basic test is provided to proof that the new `Writer` behaves as expected. 
>> For comparison, the same test is also run against `StringWriter`.
>
> Markus KARG has updated the pull request incrementally with two additional 
> commits since the last revision:
> 
>  - Undone copyright update of otherwise unchanged file.
>  - Update Of.java
>    
>    Applied changnes proposed by @liach: "the default toString already 
> includes id=..., so I usually don't provide an explicit override to make the 
> code concise."

Way too early to create a PR and CSR for this. I think close the PR for now, 
instead start a discussion on core-libs-dev to get input.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24469#issuecomment-2849357907

Reply via email to