On Sun, 4 May 2025 14:52:39 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Markus KARG has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Undone copyright update of otherwise unchanged file. >> - Update Of.java >> >> Applied changnes proposed by @liach: "the default toString already >> includes id=..., so I usually don't provide an explicit override to make the >> code concise." > > src/java.base/share/classes/java/nio/X-Buffer.java.template line 2: > >> 1: /* >> 2: * Copyright (c) 2000, 2025, Oracle and/or its affiliates. All rights >> reserved. > > Redundant change. Good catch! Undone copyright update in https://github.com/openjdk/jdk/pull/24469/commits/ea435ed1090d8f028262f5900baf0a00472726d9. > test/jdk/java/io/Writer/Of.java line 45: > >> 43: @Override >> 44: public String toString() { >> 45: return id; // allows to identify config when test case fails > > I used the same strategy in junit tests; the default toString already > includes id=..., so I usually don't provide an explicit override to make the > code concise. Understood. Removed override in https://github.com/openjdk/jdk/pull/24469/commits/f48b99995723b6c4dd73014015f50b1047ff28cd. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24469#discussion_r2072655279 PR Review Comment: https://git.openjdk.org/jdk/pull/24469#discussion_r2072654985
