On Fri, 2 May 2025 08:11:05 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> src/hotspot/share/sanitizers/ub.hpp line 39:
>>
>>> 37: #define ATTRIBUTE_NO_UBSAN
>>> __attribute__((no_sanitize("undefined","float-divide-by-zero")))
>>> 38: #endif
>>> 39: #if defined(__GNUC__) && !defined(__clang__)
>>
>> Maybe use `#elif`?
>
> Or should I try to set it for BOTH clang and gcc so that the added checks are
> not needed any more?
If you change it to #elif, then please do it in both files.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24963#discussion_r2072605220
