On Fri, 18 Apr 2025 18:31:41 GMT, simon <d...@openjdk.org> wrote: >> Javadoc for java.util.Optional.orElseThrow(Supplier) misses mentioning of >> another possible cause of a NullPointerException - when the exception >> supplying function returns a null result. >> --------- >> ### Progress >> - [ ] Change must be properly reviewed (1 review required, with at least 1 >> [Reviewer](https://openjdk.org/bylaws#reviewer)) >> - [x] Change requires CSR request >> [JDK-8354953](https://bugs.openjdk.org/browse/JDK-8354953) to be approved >> - [x] Change must not contain extraneous whitespace >> - [x] Commit message must refer to an issue >> >> ### Error >> ⚠️ The pull request body must not be empty. >> >> >> >> ### Reviewing >> <details><summary>Using <code>git</code></summary> >> >> Checkout this PR locally: \ >> `$ git fetch https://git.openjdk.org/jdk.git pull/23905/head:pull/23905` \ >> `$ git checkout pull/23905` >> >> Update a local copy of the PR: \ >> `$ git checkout pull/23905` \ >> `$ git pull https://git.openjdk.org/jdk.git pull/23905/head` >> >> </details> >> <details><summary>Using Skara CLI tools</summary> >> >> Checkout this PR locally: \ >> `$ git pr checkout 23905` >> >> View PR using the GUI difftool: \ >> `$ git pr show -t 23905` >> >> </details> >> <details><summary>Using diff file</summary> >> >> Download this PR as a diff file: \ >> <a >> href="https://git.openjdk.org/jdk/pull/23905.diff";>https://git.openjdk.org/jdk/pull/23905.diff</a> >> >> </details> > > Thank you all for the help. Let's wait for the OCA verify process. Happy to > contribute to Java. 😀
@gustavosimon Now the oca seems to be approved and the CSR is progressing. Can you update your change to match the exact specification of the CSR (wording). Please also enable GitHub actions in your fork (https://github.com/gustavosimon/jdk/actions) and merge master to get a current GHA test run (although this change is doc only and no regression is expected). ------------- PR Comment: https://git.openjdk.org/jdk/pull/23905#issuecomment-2835457882
