On Fri, 25 Apr 2025 00:06:28 GMT, Fei Yang <fy...@openjdk.org> wrote:
>> Vladimir Ivanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve comments
>
> src/hotspot/cpu/riscv/riscv.ad line 1947:
>
>> 1945: // Vector calling convention not yet implemented.
>> 1946: bool Matcher::supports_vector_calling_convention(void) {
>> 1947: return EnableVectorSupport;
>
> You might also want to remove the use of `UseVectorStubs` in
> `Matcher::vector_return_value` at L1951.
>
> assert(EnableVectorSupport && UseVectorStubs, "sanity");
Good catch. Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24462#discussion_r2059577657
