On Thu, 24 Apr 2025 16:55:16 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> test/jdk/java/io/pathNames/win32/SJIS.java line 51:
>>
>>> 49: that use the SJIS encoding */
>>> 50: String enc = System.getProperty("file.encoding");
>>> 51: if ((enc == null) || !enc.equals("SJIS")) return;
>>
>> I just wonder this test has ever run since JDK18, as file.encoding is always
>> UTF-8 unless COMPAT is specified (and this test case does not specify it)
>
> So do you think that this test should be removed? If so, I think that would
> be a different PR. Thanks.
IIUC, the test tries to create double byte path directory, so in recent jdk it
should check `sun.jnu.encoding==MS932` (it still only run on Japanese Windows
though)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24838#discussion_r2058888444
