On Wed, 23 Apr 2025 13:02:31 GMT, Emanuel Peter <epe...@openjdk.org> wrote:
>> Hi @jatin-bhateja , could you please help take a look at this PR especially >> the X86 part? Thanks a lot! >> Hi @RealFYang , could you please help review the RVV part? Thanks a lot! > > @XiaohongGong I had a quick look at your changes and PR description. I wonder > if you could split some of the refactoring into a separate PR? That would > make it easier to review. Currently, you basically have x64 changes, aarch64 > changes, Java library changes, and C2 changes. That's a lot at once. And it > would basically require the review from a lot of different people at once. > > Splitting would make it easier to review, less work for the reviewer. It > would ensure everybody can look at a smaller change set, and that would also > increase the quality of the code after review, I think. > > What do you think? > Thanks for looking at this PR @eme64 ! It's a good idea splitting this PR as > smaller ones. I will consider about this. Maybe I can do a refactoring first, > and then implement the compiler support for AArch64 as a followed-up PR. WDYT? That sounds excellent :) ------------- PR Comment: https://git.openjdk.org/jdk/pull/24679#issuecomment-2826496942
