On Wed, 23 Apr 2025 12:54:29 GMT, Alan Bateman <al...@openjdk.org> wrote:

>> src/java.base/share/classes/jdk/internal/util/SystemProps.java line 92:
>> 
>>> 90: 
>>> 91:         // Encoding properties for stdin, stdout, and stderr. For 
>>> stdout and stderr,
>>> 92:         // check "sun.*.encoding" properties before falling back to the
>> 
>> Could explain about sun* a bit more (just for compatibility) and 
>> stdin.encoding is free from it.
>
> I think the comment could be clearer. As I understand it, it's just trying to 
> saying that the legacy sun.stdout.encoding/sun.stderr.encoding properties for 
> stdout/stderr only, no equivalent for stdin.

Yeah the comment was a bit terse so I tried to clarify it.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24738#discussion_r2056537148

Reply via email to