On Mon, 21 Apr 2025 19:05:54 GMT, Joe Darcy <da...@openjdk.org> wrote:
>> David Beaumont has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Removing test from the problem list. > > test/jdk/java/util/logging/LoggingDeadlock5.java line 127: > >> 125: // in higher tiers, so it's necessary to be a bit pessimistic >> here. >> 126: private final static Duration JOIN_WAIT = >> 127: Duration.ofMillis(Utils.adjustTimeout(2000)); > > Just checking, adjustTimeout does scaling based on the timeout factor given > to jtreg? > > What happens to the expected test running time to the test in lower tiers > without as high loads? Hi Joe, yes `adjustTimeout` will scale based on the jtreg timeout factor. I believe the behaviour is to multiply whatever hardcoded timeout is passed by the timeout factor. On lower tiers, in our CI, I beleive it means the test will have to wait for 8s before it can assert that a deadlock is detected. That should be way off the default jtreg timeout - which IIRC is 480s on lower tiers. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24687#discussion_r2054172951
