On Wed, 16 Apr 2025 16:33:29 GMT, Markus KARG <d...@openjdk.org> wrote:
> If duplication is wanted, I will do it. I am just waiting for a majority to > clearly say that they want duplication. By duplication, do you mean copy pasting the `testReadBII(Reader reader)`, `testReadBIILenZero(Reader reader)`, `testReadDirectCharBuffer(Reader reader)` and similar such test methods from the existing `test/jdk/java/io/Reader/Of.java` test class? Including all those references to the `Reader`? Implementing a test that calls `Reader.of()` to verify the behaviour of an independent `CharSequence.getChars()` method isn't the kind of test I am proposing. It should be possible to just invoke `CharSequence.getChars()` on a `CharSequence` instance to verify that its default method does what it specifies. So these new tests won't be duplicating any existing test code. ------------- PR Comment: https://git.openjdk.org/jdk/pull/21730#issuecomment-2810153917
