On Tue, 8 Apr 2025 09:02:25 GMT, Hannes Wallnöfer <hann...@openjdk.org> wrote:
>> Please review an enhancement to treat classes and interfaces that are not >> included and not unconditionally exported as hidden. This means they do not >> show up in the generated documentation even if they are implemented or >> extended by a documented type. >> >> This change makes the `@hidden` JavaDoc tag unnecessary in two internal base >> classes that previously used it, `jdk.internal.vm.vector.VectorSupport` and >> `jdk.internal.event.Event`. The generated documentation is unchanged. >> >> The change also adds support for the `@hidden` JavaDoc tag in interfaces, >> which was previously missing, and adds coverage to `TestHiddenTag.java`. > > Hannes Wallnöfer has updated the pull request incrementally with one > additional commit since the last revision: > > Review feedback: add Utils.isVisible(TypeElement) method I didn't review the code changes, but I did test this by building the JDK with this fix and using the javadoc tool from that JDK to build the JavaFX docs. The non-exported intermediate classes that we currently see (without this PR) in the class hierarchy are now elided from the docs as expected. ------------- Marked as reviewed by kcr (Author). PR Review: https://git.openjdk.org/jdk/pull/24446#pullrequestreview-2761262117
