On Wed, 2 Apr 2025 18:38:17 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Kim Barrett has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - remove timeout by using waitForReferenceProcessing
>> - make ill-timed gc in non-concurrent case less likely
>> - fix test package use
>
> test/hotspot/jtreg/gc/TestNativeReferenceGet.java line 137:
>
>> 135: }
>> 136: checkQueue(); // One last check after refproc
>> complete.
>> 137: } catch (InterruptedException e) {
>
> Rather than using Reference.remove with a timeout, I've changed this to use
> waitForReferenceProcessing.
> That removes false passes (from reference processing being slow to deliver)
> and also removes the delay
> until timeout for the passing case.
https://github.com/openjdk/jdk/pull/24527 is proposing a different way to access
`waitForReferenceProcessing`. I'll wait for that.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24315#discussion_r2039040491
