On Thu, 10 Apr 2025 06:08:37 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> Brent Christian has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> reflection improvements
>
> test/lib/jdk/test/whitebox/WhiteBox.java line 578:
>
>> 576: throw new RuntimeException("Need to add @modules
>> java.base/java.lang.ref:open?",
>> 577: iae);
>> 578: } catch (NoSuchMethodException | InvocationTargetException e) {
>
> I think for InvocationTargetException the appropriate thing to do is to
> rethrow the cause, which will
> require dispatching on its dynamic type in order to cast to an appropriate
> static type. The only checked
> exception is InterruptedException. But it could also be RuntimeException or
> Error.
I simplified the exception handling.
With the default platform and jtreg behavior, stack traces include "caused by"
for the original exception. So I don't see much value in extracting the cause
ourselves
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24527#discussion_r2038440255
