On Fri, 4 Apr 2025 19:00:02 GMT, Roger Riggs <rri...@openjdk.org> wrote:
>> Now that the Security Manager is permanently disabled, the following
>> permission classes in the core libraries area can be deprecated for removal
>> as they are no longer useful: FilePermission, LinkPermission,
>> LoggingPermission, PropertyPermission, ReflectPermission, RuntimePermission,
>> and SerializablePermission
>>
>> @Deprecated(forRemoval = true, since="25")
>> Is added to each class and the existing @apiNote is converted to @deprected
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove unused import of LinkPermission
src/java.base/share/classes/java/io/FilePermission.java line 87:
> 85:
> 86: @Deprecated(since="25", forRemoval=true)
> 87: @SuppressWarnings("removal")
Is this leftover? You already add it to the methods that need it.
src/java.base/share/classes/sun/net/www/protocol/file/FileURLConnection.java
line 202:
> 200: }
> 201:
> 202: @SuppressWarnings("removal")
This should not be necessary.
src/java.logging/share/classes/java/util/logging/LoggingPermission.java line 48:
> 46: */
> 47:
> 48: @Deprecated(forRemoval = true, since="25")
This order is different than other classes, maybe make it consistent?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24444#discussion_r2029312409
PR Review Comment: https://git.openjdk.org/jdk/pull/24444#discussion_r2029308725
PR Review Comment: https://git.openjdk.org/jdk/pull/24444#discussion_r2029311303
