On Wed, 2 Apr 2025 22:27:14 GMT, Justin Lu <j...@openjdk.org> wrote:
> Please review this PR which provides unit tests for
> `ChoiceFormat#parse(String, ParsePosition)` to check default, multi match,
> and no match behavior. There were no existing relevant tests.
Looks good.
test/jdk/java/text/Format/ChoiceFormat/ParseTest.java line 71:
> 69: Arguments.of("1#a|2#aa", "aabb", 2d, 0),
> 70: Arguments.of("1#a|2#aa", "bbaa", Double.NaN, 0),
> 71: Arguments.of("1#aa|2#aaa", "a", Double.NaN, 0)
Might be useful if we had negative or beyond input length position cases, which
should produce `NaN`
-------------
PR Review: https://git.openjdk.org/jdk/pull/24395#pullrequestreview-2740682293
PR Review Comment: https://git.openjdk.org/jdk/pull/24395#discussion_r2027470610
