On Mon, 31 Mar 2025 14:43:37 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> - Don't create ".jpackage.xml" file in image for DNG or PKG bundles; >> - Remove ".jpackage.xml" file from unsigned predefined app image for DNG or >> PKG bundles; >> - Set the value of `signed` property in ".jpackage.xml" file to "true" only >> in the app image itself is signed. > > Alexey Semenyuk has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - Merge branch 'master' into JDK-8353196-full > - Fix JPackageCommand.macAppImageSigned() and move it together with > JPackageCommand.signPredefinedAppImage() to MacHelper class > - Strip ".jpackage.xml" from copied app image when permitted > - Don't create app image file on macOS when not needed > - Adjust JPackageCommand.assertAppImageFile() Looks good. Did you re-run signing tests manually just in case? ------------- Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/24313#pullrequestreview-2730606647
