On Wed, 12 Mar 2025 17:02:01 GMT, Naoto Sato <na...@openjdk.org> wrote:
>> JDK has been using JLine based Console implementation, in JDK20 as opt-in, >> then in JDK22 as the default. While it has been providing rich functionality >> for Console, it is increasingly difficult to maintain as a Console >> implementation. In light of the on-ramp feature >> (https://bugs.openjdk.org/browse/JDK-8344699), which proposes switching >> `java.lang.IO` class to use `System.in` and `System.out` instead of Console, >> reverting the default Console implementation to JDK's built-in one in the >> java.base module is considered desirable. Some tests are modified along with >> this change, among them test/jdk/java/io/Console/ConsolePromptTest.java >> changes were contributed by @lahodaj (thanks!) > > Naoto Sato has updated the pull request incrementally with one additional > commit since the last revision: > > Reflects review comment test/jdk/java/io/IO/IO.java line 166: > 164: var file = Path.of(System.getProperty("test.src", "."), > "Output.java") > 165: .toAbsolutePath().toString(); > 166: var pb = > ProcessTools.createTestJavaProcessBuilder("-Djdk.console=jdk.internal.le", > "--enable-preview", file, mode); Have you looked into changing the test so that it runs twice, the second with the jline provider? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23993#discussion_r2014109088
