On Tue, 4 Mar 2025 10:06:37 GMT, Ivan Walulya <[email protected]> wrote:
>> Thomas Schatzl has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> * iwalulya review 2
>> * G1ConcurrentRefineWorkState -> G1ConcurrentRefineSweepState
>> * some additional documentation
>
> src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp line 108:
>
>> 106:
>> 107: void G1ConcurrentRefineThreadControl::control_thread_do(ThreadClosure*
>> tc) {
>> 108: if (_control_thread != nullptr) {
>
> maybe maintain using `if (max_num_threads() > 0)` as used in
> `G1ConcurrentRefineThreadControl::initialize`, so that it is clear that
> setting `G1ConcRefinementThreads=0` effectively turns off concurrent
> refinement.
I added a new `is_refinement_enabled()` predicate instead (that uses
`max_num_threads()`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23739#discussion_r1979252156
