On Fri, 14 Feb 2025 02:23:40 GMT, SendaoYan <s...@openjdk.org> wrote:

> Hi all,
> 
> The newly added JMH tests 
> 'org.openjdk.bench.jdk.incubator.vector.VectorMultiplyOptBenchmark' fails 
> "java.lang.NoClassDefFoundError: jdk/incubator/vector/Float16" by below test 
> command:
> 
> 
> make test MICRO="FORK=1;WARMUP_ITER=2" 
> TEST="micro:org.openjdk.bench.jdk.incubator.vector.VectorMultiplyOptBenchmark.test_bm_pattern1"
> 
> 
> The `@Fork(jvmArgsPrepend = ..)` in microbenchmarks should replaced as 
> `@Fork(jvmArgs = ..)` since 
> [JDK-8343345](https://bugs.openjdk.org/browse/JDK-8343345). Change has been 
> verified locally, test-fix only, no risk.

test/micro/org/openjdk/bench/jdk/incubator/vector/Float16OperationsBenchmark.java
 line 34:

> 32: @OutputTimeUnit(TimeUnit.MILLISECONDS)
> 33: @State(Scope.Thread)
> 34: @Fork(jvmArgs = {"--add-modules=jdk.incubator.vector", "-Xbatch",  
> "-XX:-TieredCompilation"})

Suggestion:

@Fork(jvmArgs = {"--add-modules=jdk.incubator.vector", "-Xbatch", 
"-XX:-TieredCompilation"})

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23624#discussion_r1959361602

Reply via email to