On Sat, 18 Jan 2025 11:35:28 GMT, He-Pin(kerr) <d...@openjdk.org> wrote:

>> Motivation:
>> When a user passes a wrong parameter, the current implementation throws an 
>> IllegalArgumentException with an error message `null`, which is not helpful.
>> 
>> Modification:
>> Add detail error messages.
>> 
>> Result:
>> Helpful messages.
>
> I have another PR, I will wait before oca is completed.

Hi @He-Pin,

Thanks for your patience here—I've been in catch-up mode.

I didn't know there was already a PR for this issue when I created my PR for 
the issue, so in order to pick a PR to move forward with, would you prefer that 
I review your PR or would you rather move forward with the other PR?

Either works for me!

Cheers,
√

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23050#issuecomment-2647994356

Reply via email to