On Tue, 4 Feb 2025 16:56:53 GMT, Coleen Phillimore <cole...@openjdk.org> wrote:

>> Aside from JVMTI (CFLH for example), is there anything left in the VM that 
>> needs this? The last param to JVM_DefineClassWithSource has the location 
>> from the code source if available.
>
> The VM doesn't need this but it carries it around because it's a parameter to 
> JVM_DefineClass and DefineClassWithSource (second to last parameter).  CFLH 
> and CDS from what I can tell have it for the same purpose - ultimately to 
> assign it into the mirror.
> There are some remaining code in the compilers (ci).  Not sure if they are 
> needed without studying it more.

The remaining code in ci isn't necessary.  I filed and fixed another issue for 
that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23396#discussion_r1945033858

Reply via email to