On Tue, 4 Feb 2025 18:30:34 GMT, Joe Wang <jo...@openjdk.org> wrote:

> Fix an issue where the translet-name is incorrectly set when the package-name 
> is also specified.

Marked as reviewed by naoto (Reviewer).

test/jaxp/javax/xml/jaxp/libs/jaxp/library/JUnitTestUtil.java line 33:

> 31:     public static final String CLS_DIR = 
> System.getProperty("test.classes");
> 32:     public static final String SRC_DIR = System.getProperty("test.src");
> 33:     public static final boolean isWindows = 
> System.getProperty("os.name").contains("Windows");

It is good as it stands, but Platform.isWindows() can be used here

-------------

PR Review: https://git.openjdk.org/jdk/pull/23446#pullrequestreview-2599499922
PR Review Comment: https://git.openjdk.org/jdk/pull/23446#discussion_r1945195866

Reply via email to