On Wed, 5 Feb 2025 20:09:51 GMT, Alexey Semenyuk <asemen...@openjdk.org> wrote:
>> Added a test case to JLinkOptionsTest to test that jpackage doesn't bind >> services in app's runtime by default. >> >> The test builds two app images for the same app. One with the default jlink >> options and another with `--bind-services` jlink option. The test compares >> module lists from both runtimes. The expected result is that the runtime >> built with `--bind-services` jlink option has additional modules. >> >> The PR must be integrated after https://github.com/openjdk/jdk/pull/22644. >> Otherwise, the newly added test will fail. > > Alexey Semenyuk has updated the pull request incrementally with one > additional commit since the last revision: > > Use HelloApp.assertApp() to run a launcher Looks good. ------------- Marked as reviewed by almatvee (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/23047#pullrequestreview-2597130644
