On Thu, 16 Jan 2025 13:02:34 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:
>> There are 3 methods in `java.util.TimeZone` which are `public static` and >> marked as `synchronized`: >> 1. getTimeZone(String) >> 2. getAvailableIDs(int) >> 3. getAvailableIDs() >> >> This means it is a bottle neck for the whole VM. >> I've checked the implementation and concluded that `synchronized` is >> unnecessary. > > Andrey Turbanov has updated the pull request with a new target base due to a > merge or a rebase. The pull request now contains two commits: > > - Merge remote-tracking branch 'refs/remotes/origin/master' into > JDK-8291027-TimeZone-synchronized > > # Conflicts: > # src/java.base/share/classes/java/util/TimeZone.java > - 8291027: Some of TimeZone methods marked 'synchronized' unnecessarily Looks good. synchronized modifier is not reflected in Javadoc, so I think we are fine without a CSR. @naotoj can you review too, since the synchronizations here are invalid and keeping them is for no good? ------------- Marked as reviewed by liach (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17441#pullrequestreview-2572841189
