On Wed, 22 Jan 2025 18:55:10 GMT, Joe Wang <jo...@openjdk.org> wrote:
> Fix broken links in java.xml: > > Catalog: contacted Oasis. The standard page > (https://www.oasis-open.org/standard/xmlcatalogs/) now links to the PDF > version. That is what I'm using now, replacing the html pages. Not ideal, but > at least it's displayed within the browser rather than downloaded as the html > version did. > > QName: rewrote the javadocs. Looks good. Some minor nits src/java.xml/share/classes/javax/xml/namespace/QName.java line 332: > 330: > 331: /** > 332: * Returns the string representation of this {@code QName}. Could use {@return ...} construct (same for `valueOf`) src/java.xml/share/classes/javax/xml/namespace/QName.java line 358: > 356: * }</pre> > 357: * Since the {@code Prefix} is not represented in the string form, > it will be > 358: * set to {@link javax.xml.XMLConstants#DEFAULT_NS_PREFIX > XMLConstants.DEFAULT_NS_PREFIX}. Since this is in the import statement, `javax.xml.` does not seem to be needed. src/java.xml/share/classes/javax/xml/namespace/QName.java line 362: > 360: * @apiNote This method does not perform full validation of the > resulting > 361: * {@code QName}. The {@code NamespaceURI} is not validated as a > 362: * <a href="http://www.ietf.org/rfc/rfc2396.txt";>URI reference</a>. `https` would be preferred. (same for the following locations) ------------- PR Review: https://git.openjdk.org/jdk/pull/23242#pullrequestreview-2568493694 PR Review Comment: https://git.openjdk.org/jdk/pull/23242#discussion_r1926106540 PR Review Comment: https://git.openjdk.org/jdk/pull/23242#discussion_r1926115569 PR Review Comment: https://git.openjdk.org/jdk/pull/23242#discussion_r1926115385
