On Mon, 20 Jan 2025 17:28:40 GMT, Raffaello Giulietti <rgiulie...@openjdk.org> wrote:
>> Shaojin Wen has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 29 additional >> commits since the last revision: >> >> - Merge remote-tracking branch 'upstream/master' into >> int_get_chars_dedup_202411 >> - fix comments >> - use putCharUnaligned >> - bug fix >> - from rgiulietti >> - Coding style consistency, from rgiulietti >> - fix benchmark, from rgiulietti >> - Coding style consistency, from rgiulietti >> - fix comment >> - fix comment, from @rgiulietti >> - ... and 19 more: https://git.openjdk.org/jdk/compare/e8af273a...be1f88ab > > Do you prefer to postpone that analysis to a followup PR, so that we can > integrate this one and move on? > Up to you ;-) Thanks @rgiulietti I found out that the reason for the slowdown on x64 may not be related to the changes in this PR, because I reverted the code to (d22a28607edba719850af807934ac39a7c332d13) in the current PR branch, and the performance is the same. I suspect that the master version C2 has new optimizations. I think it can be integrated, and further optimization can be put in the next step. My next optimization plan is to change the length of DIGITS to 128 and use `DIGITS[v & 0x7f]` to eliminate array bounds checks. ------------- PR Comment: https://git.openjdk.org/jdk/pull/22023#issuecomment-2603529847
