On Thu, 16 Jan 2025 23:38:48 GMT, Naoto Sato <na...@openjdk.org> wrote:
> This fix is a follow on for > [JDK-8342550](https://bugs.openjdk.org/browse/JDK-8342550). Replaces/Removes > usages of those deprecated time zone ids in tests. Looks good. test/jdk/java/text/Format/DateFormat/DateFormatTest.java line 190: > 188: //logln(((SimpleDateFormat)fmt).toPattern()); > 189: TimeZone save = TimeZone.getDefault(); > 190: TimeZone PST = TimeZone.getTimeZone("America/Los_Angeles"); nit: extra space after "PST" here and below. test/jdk/java/util/TimeZone/TimeZoneBoundaryTest.java line 417: > 415: //findBoundariesStepwise(1997, ONE_DAY, > TimeZone.getTimeZone("EST"), 2); > 416: findBoundariesStepwise(1997, ONE_DAY, > TimeZone.getTimeZone("HST"), 0); > 417: findBoundariesStepwise(1997, ONE_DAY, > TimeZone.getTimeZone("PST"), 2); "PST" to "America/Los_Angeles" not needed? ------------- Marked as reviewed by jlu (Committer). PR Review: https://git.openjdk.org/jdk/pull/23166#pullrequestreview-2557677590 PR Review Comment: https://git.openjdk.org/jdk/pull/23166#discussion_r1919401497 PR Review Comment: https://git.openjdk.org/jdk/pull/23166#discussion_r1919380627