On Fri, 20 Dec 2024 19:27:00 GMT, Liam Miller-Cushon <cus...@openjdk.org> wrote:

>> Please consider this fix for 
>> [JDK-8323740](https://bugs.openjdk.org/browse/JDK-8323740), which avoids an 
>> `ExceptionInInitializerError` in the class initializer of 
>> `XMLDocumentFragmentScannerImpl` and other classes that have a circular 
>> dependency on `jdk.xml.internal.JdkXmlUtils`. The change breaks the cycle by 
>> moving some initialization out of the class initializer of `JdkXmlUtils`.
>
> Liam Miller-Cushon has updated the pull request with a new target base due to 
> a merge or a rebase. The incremental webrev excludes the unrelated changes 
> brought in by the merge/rebase. The pull request contains two additional 
> commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/master' into JDK-8323740
>  - 8323740: java.lang.ExceptionInInitializerError when trying to load XML 
> classes in wrong order

Looks good.

To answer Alan's question, it's unlikely to arise when using just the 
exported/supported API since the util class will generally be loaded early 
during the initialization process.

-------------

Marked as reviewed by joehw (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22803#pullrequestreview-2548837020

Reply via email to